Fix a few parser style issues. #2442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue is that lexer_hex_to_character is used by some internal tests. I don't really like this, but we can keep it if needed. |
|
Any suggestion? |
|
Let's keep it or declare as an extern function in the related unit test file. |
|
My two cents: keep Some (distant?) future work may deal with solving this, i.e., how to make those functions static that are only published for testing reasons. But that will deal with all such functions then, not only this one. |
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
zherczeg
force-pushed
the
parser_style_fixes
branch
from
c9df788 to
ae57d20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.